Skip to content

Conversation

lucien-nxp
Copy link
Contributor

@lucien-nxp lucien-nxp commented Sep 5, 2025

  1. add frdm_mcxe31b board support
  2. enable cases below:
    hello_world/blinky/button/philosophers/synchronization
  3. add mcxe31x series soc

Copy link

github-actions bot commented Sep 5, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@4377ecf zephyrproject-rtos/hal_nxp@f33ec8f (master) zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_nxp DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Sep 5, 2025
@lucien-nxp lucien-nxp force-pushed the add_mcxe31x_baseline_support branch from 0d95a80 to 5d68882 Compare September 5, 2025 16:32
@lucien-nxp lucien-nxp changed the title Add frdm_mcxe31 board basic support Add frdm_mcxe31b board basic support Sep 5, 2025
@lucien-nxp lucien-nxp force-pushed the add_mcxe31x_baseline_support branch from 5d68882 to 3ef987b Compare September 5, 2025 18:10
@lucien-nxp lucien-nxp requested a review from ChayGuo September 18, 2025 09:50
Comment on lines 46 to 47
config ROM_START_OFFSET
default 0x1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goes in Kconfig.defconfig

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved.

#

if(CONFIG_NXP_MCXE31X_BOOT_HEADER)
zephyr_library_sources(boot_header/boot_header.c)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 space indent for cmake

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

const uint32_t *reserved5; /* Reserved */
const uint32_t *reserved6; /* Reserved */
const uint32_t *lcc_config; /* Address of LC config */
uint8_t Reserved7[216]; /* Reserved for future use */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snake case not camel case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, miss it. I have modified and use AI tool help check, there is no camel issue on boot_header files


leds {
compatible = "gpio-leds";
red_led: led_0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix in whole PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check for all the dts files, it should be there is no missed newline issue for same device level definition.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still see a missing newline on line 37 and other places, Fix in the whole PR

@lucien-nxp lucien-nxp force-pushed the add_mcxe31x_baseline_support branch 4 times, most recently from f2b7edb to d777dfa Compare September 20, 2025 13:47
@hakehuang
Copy link
Contributor

hakehuang commented Sep 22, 2025

board testing pass on v4.2.0-3891-gd777dfa367ce, with kernel and gpio testing

hakehuang
hakehuang previously approved these changes Sep 22, 2025
@lucien-nxp
Copy link
Contributor Author

I will resolve conflict and sync the newest commit node on hal_nxp side after PR in hal_nxp side merged.

@lucien-nxp lucien-nxp requested a review from nordicjm September 29, 2025 13:43

#if DT_NODE_HAS_COMPAT_STATUS(DT_NODELABEL(fxosc), nxp_fxosc, okay)
const fxosc_config_t fxosc_config = {.freqHz = NXP_FXOSC_FREQ,
.workMode = NXP_FXOSC_WORKMODE,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have these files been put through clang-format? Because the struct here looks very odd

default y
depends on DT_HAS_NXP_S32ZE_SIUL2_PINCTRL_ENABLED || DT_HAS_NXP_S32K3_SIUL2_PINCTRL_ENABLED
depends on DT_HAS_NXP_S32ZE_SIUL2_PINCTRL_ENABLED || DT_HAS_NXP_S32K3_SIUL2_PINCTRL_ENABLED || \
DT_HAS_NXP_MCXE31X_SIUL2_PINCTRL_ENABLED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DT_HAS_NXP_MCXE31X_SIUL2_PINCTRL_ENABLED
DT_HAS_NXP_MCXE31X_SIUL2_PINCTRL_ENABLED

cpus {
#address-cells = <0x1>;
#size-cells = <0>;
core0: cpu@0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline on line 15

&peripheral {
#address-cells = <1>;
#size-cells = <1>;
adc_0: adc@a0000 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

etc. fix in whole PR

@@ -0,0 +1,10 @@
#
# Copyright 2025 NXP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove excess spacing from commit title

# Copyright 2025 NXP
# SPDX-License-Identifier: Apache-2.0

config NXP_MCXE31X_BOOT_HEADER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BOARD_ prefix missing

/*
* Copyright 2025 NXP
*
* SPDXLicense-Identifier: Apache-2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs fixing


leds {
compatible = "gpio-leds";
red_led: led_0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still see a missing newline on line 37 and other places, Fix in the whole PR

Updated hal_nxp to add mcxe31x pinctrl.h

Signed-off-by: Lucien Zhao <[email protected]>
- add clock_init function to initialize clock sources according
  devicetree settings
- finish basic clock api function

Signed-off-by: Lucien Zhao <[email protected]>
- adapt for mcxe31x series
- due to some bit defined in header files
  add some conditional macro to separate

Signed-off-by: Lucien Zhao <[email protected]>
- add binding files: nxp,mcxe31x-siul2-pinctrl.yaml
- Enable PINCTRL_NXP_SIUL2 when nxp,mcxe31x-siul2-pinctrl is ok

Signed-off-by: Lucien Zhao <[email protected]>
- create 'mcxe' as family and 'mcxe31x' as series
- add pinctrl_soc.h
- add soc.c/.h to do some soc level initialization
- add ecc initialization in mcxe31x_soc_initialization.S

Signed-off-by: Lucien Zhao <[email protected]>
- Generate a full devices device tree file
- Use specific_part.dtsi + full_devices.dtsi way to
  desribe all devices

Signed-off-by: Lucien Zhao <[email protected]>
- support XIP way to boot
- add board doc and picture
- enable cases below:
    hello_world/blinky/button/
    philosophers/synchronization/
    gpio_basic_api

Signed-off-by: Lucien Zhao <[email protected]>
@dleach02 dleach02 force-pushed the add_mcxe31x_baseline_support branch from d777dfa to 96f1e57 Compare October 8, 2025 21:25
@github-actions github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Oct 8, 2025
@zephyrbot zephyrbot added platform: NXP MCU area: Boards/SoCs area: Tests Issues related to a particular existing or missing test area: Devicetree Bindings labels Oct 8, 2025
@dleach02
Copy link
Member

dleach02 commented Oct 8, 2025

@lucien-nxp I merged the HAL side PR and updated this PR for you.

@zephyrbot zephyrbot requested a review from nashif October 8, 2025 21:28
Copy link

sonarqubecloud bot commented Oct 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants